FEATURE: 3334 Resource targets without space tunnels#3445
Draft
mhsdesign wants to merge 2 commits into
Draft
Conversation
mhsdesign
commented
Feb 13, 2025
| /** @var TargetInterface $target */ | ||
| $target = $this->collections[self::DEFAULT_STATIC_COLLECTION_NAME]->getTarget(); | ||
| if ($target instanceof AbsoluteBaseUriAwareTarget) { | ||
| $target->setAbsoluteBaseUri($baseUri ?? $this->baseUriProvider->getConfiguredBaseUriOrFallbackToCurrentRequest()); |
Member
Author
There was a problem hiding this comment.
technically absoluteBaseUri is not fully correct, as the api would also allow passing an empty uri: new Uri('')
Now the value returned by getConfiguredBaseUriOrFallbackToCurrentRequest is likely just the plain host but might also contain the dir of the request path $SCRIPT_NAME.
That would fit with the description of absolute uri.
Now as soon as Neos.Flow.http.baseUri is not null even an empty string would be returned which does NOT fit again into idea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wip resolves: #3334
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions